[Webkit-unassigned] [Bug 52460] [Qt] Fixed compilation when QT_NO_SHORTCUT is defined

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52460


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78964|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin.poulain at nokia.com>  2011-01-14 11:16:34 PST ---
(From update of attachment 78964)
View in context: https://bugs.webkit.org/attachment.cgi?id=78964&action=review

> WebKit/qt/ChangeLog:8
> +        This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt configuration

<Kenneth>A dot at the end of the sentence!</Kenneth>

> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:484
> +#ifndef QT_NO_SHORTCUT
>          }
> -
> +#endif

I would rather see 
} else
#endif // QT_NO_SHORTCUT
{
a dozen of lines above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.