[Webkit-unassigned] [Bug 52434] [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52434


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78915|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2011-01-14 02:40:58 PST ---
(From update of attachment 78915)
View in context: https://bugs.webkit.org/attachment.cgi?id=78915&action=review

Now that I had a second chance to look at it. I think it could be slightly better since you are making this change. Sorry for not noticing last time.

> Source/WebCore/platform/gtk/FileSystemGtk.cpp:51
>      return string;

I wonder why you don't just do
   return String(escapedString.get());

And the same for the other three places where you did a change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.