[Webkit-unassigned] [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52422


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78889|review?                     |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2011-01-13 22:28:52 PST ---
(From update of attachment 78889)
View in context: https://bugs.webkit.org/attachment.cgi?id=78889&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests. (OOPS!)

oops. :)

This line should be removed.  Ideally there would be a test.

What about doing what you mentioned in the bug or something like that? Would that cause a crash that is fixed by this change?

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:593
> +        if (simpleFont = getCachedFontData(description, fallbackFonts[i])) {

Consider a fail fast approach.

if (!(simpleFont = getCachedFontData(description, fallbackFonts[i])))
    continue;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.