[Webkit-unassigned] [Bug 52423] New: RenderObject::canHaveChildren()==false prevents shadow renderer creation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 22:00:16 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52423

           Summary: RenderObject::canHaveChildren()==false prevents shadow
                    renderer creation
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tkent at chromium.org
                CC: dglazkov at chromium.org, morrita at google.com
            Blocks: 48698


Some renderers return false for canHaveChildren().  So if we try to convert the legacy shadow DOM code to the new API, the shadow nodes won't have their renderers.  See Node::createRendererIfNeeded().

dglazkov said:
> I think it should be a function on an Element which indicates whether its children should be rendered

Source/WebCore/rendering/RenderButton.h:    virtual bool canHaveChildren() const;
Source/WebCore/rendering/RenderDataGrid.h:    virtual bool canHaveChildren() const { return false; }
Source/WebCore/rendering/RenderIndicator.h:    virtual bool canHaveChildren() const { return false; }
Source/WebCore/rendering/RenderListBox.h:    virtual bool canHaveChildren() const { return false; }
Source/WebCore/rendering/RenderMenuList.h:    virtual bool canHaveChildren() const { return false; }
Source/WebCore/rendering/RenderReplaced.h:    virtual bool canHaveChildren() const { return false; }
Source/WebCore/rendering/RenderTableCol.h:    virtual bool canHaveChildren() const;
Source/WebCore/rendering/RenderTextControl.h:    virtual bool canHaveChildren() const { return false; }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list