[Webkit-unassigned] [Bug 52401] New: Make CheckedInt<long> and CheckedInt<unsigned long> work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 15:13:48 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52401

           Summary: Make CheckedInt<long> and CheckedInt<unsigned long>
                    work
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zmo at google.com
                CC: cmarrin at apple.com, kbr at google.com, enne at google.com


Currently CheckedInt<int>, CheckedInt<long long> works, but not CheckedInt<long>.

>From compiling error, seems like the code was confused on what's the next level of integer above long.

That should be platform dependent.  If long is 32bit, then the next level should be long long.  If long is 64 bit, then the  next level should be undefined.

Fixing this could simply be a check of the sizeof(long) and map it either to int or long long.

Once this is fixed, we should use GC3D types when using CheckedInt instead of int32_t and uint32_t we currently use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list