[Webkit-unassigned] [Bug 52380] Lazily generate and store logical ordering of InlineBoxes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52380


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78836|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2011-01-13 14:10:23 PST ---
(From update of attachment 78836)
View in context: https://bugs.webkit.org/attachment.cgi?id=78836&action=review

I suspect this is not invalidating when necessary.

> Source/WebCore/editing/visible_units.cpp:1039
> +    const Vector<InlineBox*> leafBoxesInLogicalOrder = rootBox->leafBoxesInLogicalOrder();

I don't think you want the const here. seems meaningless.

> Source/WebCore/rendering/RootInlineBox.cpp:219
> +    m_leafBoxesInLogicalOrder.clear();

Don't we need to invalidate thsi when adding children too?

> Source/WebCore/rendering/RootInlineBox.cpp:566
> +void RootInlineBox::determineLogicalOrderOfLeafBoxes() const

I assume this is just copied from the previous location and otherwise not modified (except to store in a vector)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.