[Webkit-unassigned] [Bug 50928] RTL: Select elements with a size attribute are always left aligned

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50928





--- Comment #5 from Xiaomei Ji <xji at chromium.org>  2011-01-13 12:32:39 PST ---
(From update of attachment 78801)
View in context: https://bugs.webkit.org/attachment.cgi?id=78801&action=review

> Source/WebCore/rendering/RenderListBox.cpp:306
> +

Thanks for the patch!
Seems that renderStyle() returns the <select>'s style even if the style is set in <option>. So, alignment style in <option> is ignored and <option> always aligned according to <select>'s alignment (or implied from direction). 
Is this expected behavior? and is it defined in standard?

> Source/WebCore/rendering/RenderListBox.cpp:334


ETextAlign actualAlignment = itemStyle->textAlign()

> Source/WebCore/rendering/RenderListBox.cpp:335
> +    // FIXME: Firefox doesn't respect JUSTIFY. Should we?

I think we should. then, remove this line?

> Source/WebCore/rendering/RenderListBox.cpp:349
> +      r.setWidth(textWidth);
> +    } else if (actualAlignment == CENTER) {

else if (actualAlignment == CENTER || actualAlignment == WEBKIT_CENTER)

> Source/WebCore/rendering/RenderListBox.cpp:352
> +      r.setWidth(textWidth);

why need setWidth here (and above)?

>> Source/WebCore/rendering/RenderListBox.cpp:355

> 
> This is something the RTL folks should check.

Seems <select>/<option> never truncate, so above logic is correct.
This code is not shared by <input> or other element that truncation could happen, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.