[Webkit-unassigned] [Bug 52380] New: Lazily generate and store logical ordering of InlineBoxes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52380

           Summary: Lazily generate and store logical ordering of
                    InlineBoxes
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: leviw at google.com
                CC: hyatt at apple.com, mitz at webkit.org, xji at chromium.org,
                    rniwa at webkit.org



Levi Weintraub <leviw at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78828|                            |review?
               Flag|                            |


Created an attachment (id=78828)
 --> (https://bugs.webkit.org/attachment.cgi?id=78828&action=review)
Proposed patch

Currently, iterating across InlineBoxes logically involves an n^2 algorithm and the result isn't stored. For RTL and BiDi content, this can represent a lot of wasted work, particularly as new places pop up that need access to this info (see https://bugs.webkit.org/show_bug.cgi?id=38087).

I propose lazily generating this ordering and storing it so future lookups and iteration are O(1). I've also moved the algorithm to RootInlineBox so it hopefully will be updated with Rendering changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.