[Webkit-unassigned] [Bug 52327] [GTK] Move text field painting out of gtk2drawing.c

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52327





--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-13 08:50:50 PST ---
(From update of attachment 78773)
View in context: https://bugs.webkit.org/attachment.cgi?id=78773&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:363
> +    backgroundRect.inflateX(-style->xthickness);
> +    backgroundRect.inflateY(-style->ythickness);

GTK+ doesn't take into account thickness (only when drawing spin buttons) when drawing both bg and frame, so I think we can use the same rectangle. See gtk+ code:

http://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-2-24#n3282
http://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-2-24#n3440

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:369
> +    gboolean interiorFocus = 0;

We don't need to initialize this, gtk_widget_style_get() always returns a value for booleans

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.