[Webkit-unassigned] [Bug 52311] [chromium] Add command-line flag to enable composite to offscreen texture.

Thu Jan 13 08:02:52 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52311

--- Comment #13 from W. James MacLean <wjmaclean at chromium.org>  2011-01-13 08:02:52 PST ---
(In reply to comment #10)
> What I was suggesting is that if you make this change, you should be able to call useRenderSurface(0) here instead of making all the individual calls.  Would that work?

Ahh, so you're suggesting using it to simplify copyOffscreenTextureToDisplay()? If so, then yes, it seems to work well (see new patch). If this is not what you had in mind let me know.

(In reply to comment #11)
> > 
> > Will this work if setCompositeOffscreen(true) isn't called inside of doComposite(), i.e. it's called once when the render layer is created an then never again?
> 
> It should, in theory. If you clear the alpha channel of the backbuffer once at the very beginning and then mask alpha writes off, then the alpha channel should stay clean.

OK, I've implemented this, and it seems to test OK. I've moved the call to setCompositeOffscreen() to WebViewImpl::resize() to avoid clearing the screen on each and every call to doComposite(), but making sure to clear whenever the screen size changes. Question: is WebViewImpl::resize() guaranteed to be called at least once before doComposite()? I'm guessing 'yes', and it seems to test OK, but I'm not 100% sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.