[Webkit-unassigned] [Bug 52200] Small filter primitive renderer improvements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 05:53:28 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52200





--- Comment #9 from Zoltan Herczeg <zherczeg at webkit.org>  2011-01-13 05:53:27 PST ---
Thanks for the review.

> > Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:76
> > +    RefPtr<FilterEffect> effectReference = passEffectReference;
> >      ASSERT(!m_effectReferences.contains(effectReference));
> > +    ASSERT(object && !m_effectRenderer.contains(object));
> 
> You're right, a functions should always take the ownership, but IIRC you don't touch passEffectReference in this function, but just save it in m_effectRenderer. So do we need to store it in effectReference? Can't we just store it m_effectRenderer? Also, do all callers of appendEffectToEffectRef...() release the passed effect? - Ah you store RefPtr in two member variables, m_effectReferences and m_effectRenderer. Hm, not sure what behavior is correct here.

No idea about the best solution here. I think passing RefPtr-s is against the style (not sure...). Directly using PassRefPtr-s cause a segfault, so I need to define a local variable before use. Of course I could revert these lines to the original one if you prefer them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list