[Webkit-unassigned] [Bug 52258] [GTK] Move toggle button rendering out of gtk2drawing.c

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52258


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com




--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-13 01:22:35 PST ---
(In reply to comment #5)
> > Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:178
> > +    GdkRectangle paintRect = { m_paintRect.x + rect.x(), m_paintRect.y + rect.y(), rect.width(), rect.height() };
> 
> I think we should paint the indicator centered, mozilla code did it 
> y = rect->y + (rect->height - indicator_size) / 2;

nevermind, in current code rect->height == indicator_size

> > Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:186
> > +    GdkRectangle paintRect = { m_paintRect.x + rect.x(), m_paintRect.y + rect.y(), rect.width(), rect.height() };
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.