[Webkit-unassigned] [Bug 48510] [GTK] Implement WebEventFactory, WebErrors, Module, WebPage, WebContext, NativeKeyboardEvent classes for WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 21:40:55 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=48510





--- Comment #8 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-01-12 21:40:55 PST ---
(In reply to comment #7)
> (From update of attachment 78236 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78236&action=review
> 
> I think you could split the patch into different independent pieces.
The patch has majorly stubbed implementations except for WebPageGtk.cpp. Do you want us split WebPageGtk.cpp to separate patch & keep rest of the files as separate patch?
> 
> > WebKit2/ChangeLog:9
> > +        * Platform/Module.h:
> > +        * Platform/gtk/ModuleGtk.cpp: Added. Initial code using dlopen/dlclose calls (UNIX_X11 specific).
> 
> We should use GModule instead since it's portable.
We will address this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list