[Webkit-unassigned] [Bug 52333] Add support to DumpRenderTree to use the GPU rather than software renderer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52333





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2011-01-12 18:30:37 PST ---
(From update of attachment 78754)
View in context: https://bugs.webkit.org/attachment.cgi?id=78754&action=review

The change looks fine. Semi-unrelated note: will we be able to remove the --accelerated-* flags (to new-run-webkit-tests, not to DRT/TestShell) at some point soon because those code paths should always be on?

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:396
> +                cmd.append('--test-on-GPU-hardware')

Typically we wouldn't use mixed-case for this. I might call the switch something shorter like --use-hardware-gpu .

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:249
> +            help="Run OpenGL commands on real GPU hardware vs software"),

For now, this way of declaring things is fine. 

If we do something like what I discussed earlier, where default should vary depending on whether you use --platform chromium-win or --platform chromium-gpu-win, then you would want a default=None (not setting default= as an argument has the same effect) and then test for None explicitly in the Port code to see if the flag was set on the command line or if we need to specify the default. This is a result of the unfortunate fact of argument parsing happening before we get to execute any Port code (which I'll fix at some point, but not now).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.