[Webkit-unassigned] [Bug 51960] review tool formatted diff doesn't match the uploaded diff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51960





--- Comment #12 from Adam Roben (aroben) <aroben at apple.com>  2011-01-12 11:34:08 PST ---
(In reply to comment #11)
> Actually, I wonder if there are cases where uploaded patches don't end in a newline? We should probably change that code to add a newline only if it doesn't already end in one?

It should be easy to test what happens when there's no trailing newline. If PrettyPatch behaves itself then we can just get rid of the ' . "\n"' part of that line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.