[Webkit-unassigned] [Bug 52211] FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52211





--- Comment #4 from Joe Mason <jmason at rim.com>  2011-01-12 07:52:24 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > jnd is our user gesture expert.  Thoughts?
> 
> I think Joe's patch is on the right way to fix this issue.
> My only question is:
> Is that necessary to restore the gesture state when calling clientRedirectCancelledOrFinished?
> what scenarios need to know the gesture state of canceled redirection in the didCancelClientRedirect callback?

Actually I meant to take that out.  In fact, didCancelClientRedirect gets called from several completely different code paths, and in at least one other - namely when the redirect actually succeeds and the new page finishes loading - the gesture state isn't set, and it's unclear how it could be set.

So if we set it here, the gesture state in didCancelClientRedirect will be inconsistent - sometimes it will be the same as when the redirect started, and sometimes not.  This isn't useful to anybody.

The correct thing for the client to do if they want to know the gesture state in didCancelClientRedirect is to save it in willPerformClientRedirect and check (and clear) the saved state in didCancelClientRedirect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.