[Webkit-unassigned] [Bug 5241] Space and tab characters "sent" by an input method give totally different results than typing them directly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5241





--- Comment #12 from MORITA Hajime <morrita at google.com>  2011-01-11 20:55:21 PST ---
(In reply to comment #10)
> Please address the comments I made on the bug 51918.
I'm sorry I missed it. I updated the patch to address it.

(In reply to comment #3)
> (From update of attachment 78211 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78211&action=review
> 
> > LayoutTests/ChangeLog:7
> > +
> 
> You probably want to explain what kind of test you're adding.
Added an explanation.

> 
> > WebCore/editing/CompositeEditCommand.cpp:433
> > +String CompositeEditCommand::stringWithBalancedWhitespaceAt(const Position& position, const String& text)
> 
> Nit: the original function name "rebalanceWhitespaceAt" is better IMO.
Renamed to "rebalanceWhitespaceBetweenWordsAt", which indicates its intension more closely.

> 
> > WebCore/editing/CompositeEditCommand.cpp:438
> > +    String ret;
> 
> Nit: please don't use abbreviation.
Fixed.

> 
> > WebCore/editing/CompositeEditCommand.cpp:469
> > +    }
> 
> Why aren't we calling stringWithRebalancedWhitespace in htmlediting.cpp?
It is for dirrent purpose. stringWithRebalancedWhitespace is for leading/trailing whitespace.
new one is for whitespace other than leading/trailing. I renamed the function to indicate that.

> 
> > WebCore/editing/Editor.cpp:1604
> > +    // Some IME pass sequence of whitespace ' ' instead of nbsp even they expect
> > +    // multiple whitespaces inserted into the redering result. 
> > +    // So we mix some nbsp characters for preserving the whitespace.
> 
> Nit: I don't think this comment is necessary.  Anyone who knows about whitespace rebalancing would understand what this code does.
Removed.

> 
> > WebCore/editing/Editor.cpp:1696
> > +        // Some IME pass sequence of whitespace ' ' instead of nbsp even they expect
> > +        // multiple whitespaces inserted into the redering result. 
> > +        // So we mix some nbsp characters for preserving the whitespace.
> 
> Ditto.
Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.