[Webkit-unassigned] [Bug 51673] chrome.dll!WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks ReadAV at NULL (920f5522b6092d55727c9be058273715)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 15:06:18 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51673





--- Comment #12 from Adam Barth <abarth at webkit.org>  2011-01-11 15:06:18 PST ---
(From update of attachment 78456)
View in context: https://bugs.webkit.org/attachment.cgi?id=78456&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:152
> -         focus();
> +        queuePostAttachCallback(focusElementCallback, this);

Do we need to hold a reference to |this| to ensure it doesn't get deleted?  What if JavaScript calls focus on another done after this line of code executes but before the post-attach callback...  I'm just a bit skeptical of this approach, but I don't have anything better to suggest.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list