[Webkit-unassigned] [Bug 52221] Autocorrection should respect undo.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52221


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mitz at webkit.org




--- Comment #5 from mitz at webkit.org  2011-01-11 11:02:42 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=78548&action=review

> WebCore/editing/Editor.cpp:1125
> +    RefPtr<Range> range = Range::create(document, newSelection.start(), newSelection.end());
> +    // If the text is inserted by undo, it should be exempt from autocorrection.
> +    // This is especially important when user reverts an autocorrection by undo.
> +    document->markers()->addMarker(range.get(), DocumentMarker::Replacement);
> +#endif

Is this going to make all text inserted by undo marked as replacement? Are those marks ever cleared?

> WebCore/rendering/InlineTextBox.cpp:1033
> +                // Other markers are for intenal annotation, and don't require update on UI.

typo: “intenal”

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.