[Webkit-unassigned] [Bug 52222] Microoptimization in ~JSString

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 10:52:19 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52222


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2011-01-11 10:52:19 PST ---
(In reply to comment #2)
> (From update of attachment 78544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78544&action=review
> 
> > Source/JavaScriptCore/runtime/JSString.h:324
> > +                do {
> > +                    RopeImpl::deref(m_other.m_fibers[i]);
> > +                } while (++i < m_fiberCount);
> 
> One line body, usually no braces in WebKit coding style.

You are right; for some reason the do without the braces seemed weird, but it goes against the style guidelines. Committed with that fix as http://trac.webkit.org/changeset/75517

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list