[Webkit-unassigned] [Bug 52200] Small filter primitive renderer improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52200





--- Comment #5 from Dirk Schulze <krit at webkit.org>  2011-01-11 10:03:46 PST ---
(From update of attachment 78517)
View in context: https://bugs.webkit.org/attachment.cgi?id=78517&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:333
> +void RenderSVGResourceFilter::repaintFilterPrimitve(RenderObject* object)
> +{
> +    RenderObject* filter = object->parent();
> +    if (!filter || !filter->isSVGResourceFilter())
> +        return;
> +    filter->repaint();
> +}

This function is never called right now, can describe what you plan to do with it please?

> Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:43
> +    SVGFilter* filter = reinterpret_cast<SVGFilter*>(effect->filter());

We normally use static_casts

> Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h:51
> +    void invalidate(bool repaint = false);

do you really mean repaint or relayout?

> Source/WebCore/svg/SVGFEOffsetElement.cpp:69
> +    if (attrName == SVGNames::dxAttr || attrName == SVGNames::dyAttr)
> +        invalidate(true);

This is unclear to me. Do we want to repaint or relayout? Changing dx or dy definitely affects the repaintRect size of following filter primitives, ergo relayout, right?

> Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h:58
>          if (RenderObject* primitiveRenderer = renderer())
> -            RenderSVGResource::markForLayoutAndParentResourceInvalidation(primitiveRenderer);
> +            reinterpret_cast<RenderSVGResourceFilterPrimitive*>(primitiveRenderer)->invalidate(repaint);
>      }

Why no static_cast?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.