[Webkit-unassigned] [Bug 51454] [GTK] Implement spin buttons in RenderThemeGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51454





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-01-11 09:37:39 PST ---
(From update of attachment 78505)
View in context: https://bugs.webkit.org/attachment.cgi?id=78505&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:779
> +    GtkBorder padding;
> +    gtk_style_context_get_padding(context, static_cast<GtkStateFlags>(0), &padding);
> +
> +    int width = spinButtonArrowSize(context) + padding.left + padding.right;
> +    style->setWidth(Length(width, Fixed));
> +    style->setMinWidth(Length(width, Fixed));
> +}

Is it possible to just use reasonable values here rather than staying entirely true to the theme. If so, it might be better, as it will allow us to have the same layout regardless of the GTK+ theme / version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.