[Webkit-unassigned] [Bug 45186] Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 11 08:58:44 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=45186
--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-01-11 08:58:44 PST ---
Attachment 78538 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/FastMalloc.cpp:1442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1447: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1448: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1450: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1498: TCMalloc_PageHeap::initializeScavenger is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1500: Use 0 instead of NULL. [readability/null] [5]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1504: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1504: Missing space before { [whitespace/braces] [5]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1524: TCMalloc_PageHeap::initializeScavenger is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2408: TCMalloc_PageHeap::periodicScavenge is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 11 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list