[Webkit-unassigned] [Bug 52203] New: [GTK] Remove m_themeParts and m_themePartsHaveRGBAColormap from RenderThemeGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52203

           Summary: [GTK] Remove m_themeParts and
                    m_themePartsHaveRGBAColormap from RenderThemeGtk
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cgarcia at igalia.com


gtk2drawing.c uses a global static pointer to a GtkThemeParts struct that is set with moz_gtk_use_theme_parts(). RenderThemeGtk2 calls moz_gtk_use_theme_parts() passing m_themeParts, but only for the first RenderThemeGtk instance since it's using a static reference counter. Once there's a RenderThemeGtk instance, all other new instances will have a GtkThemeParts that it's not used except to set the colormap. Since gtk2drawing.c uses a global pointer that is set only once, we could use a static struct instead of an instance member in RenderThemeGtk2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.