[Webkit-unassigned] [Bug 52197] Use definition of PI from MathExtras.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 03:03:06 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52197


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78497|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2011-01-11 03:03:06 PST ---
(From update of attachment 78497)
View in context: https://bugs.webkit.org/attachment.cgi?id=78497&action=review

Looks great.  But we need to fix the ChangeLog first or the commit-queue will fail to process it.

> Source/WebCore/ChangeLog:7
> +        Need a short description and bug URL (OOPS!)

This will prevent the cq from being able to land this.  the -b option to prepare-ChangeLog will fill this in automatically for you, or just using "webkit-patch upload" will fill it in too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list