[Webkit-unassigned] [Bug 52182] Patch holder while updating over WebCore->Source/WebCore tectonic boundary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52182


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-01-10 17:54:37 PST ---
Attachment 78482 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.cpp:94:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSParser.cpp:1083:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/css/CSSParser.cpp:1084:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/css/CSSParser.cpp:1089:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/CSSParser.cpp:5503:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/css/CSSParser.cpp:5508:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/CSSParser.h:170:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.