[Webkit-unassigned] [Bug 51134] Move loading related code from MemoryCache to CachedResourceLoader

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 03:15:15 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51134





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2011-01-10 03:15:14 PST ---
(In reply to comment #10)
> Are you sure this is the case? I have a sneaking suspicion that this change is causing random memory heap corruption issues, as being investigated here:
> 
> http://code.google.com/p/chromium/issues/detail?id=68516

If CSSImageValue::cachedImage was called with null loader (which is the case I removed), it seems certain it would crash immediately when dereferencing in

if (CachedImage* cachedImage = loader->requestImage(url)) {

I can't see how it could survive that to corrupt memory. 

Can you enable that ASSERT(loader) crash in your reliability bot build to be sure?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list