[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #33 from Grzegorz <g.czajkowski at samsung.com>  2011-01-10 02:29:36 PST ---
(In reply to comment #28)
> (From update of attachment 77985 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77985&action=review
> 

> > +Eina_Bool ewk_settings_disable_cache_set(Eina_Bool set)
> 
> This name is really weird because there are 2 verbs "disable" and "set". Could you rename it to ewk_settings_cache_disabled_set?

renamed

> 
> > WebKit/efl/ewk/ewk_settings.cpp:307
> > +    if (cache->disabled() != set) 
> 
> Since this is EAPI, you can't really trust user passed EINA_TRUE or EINA_FALSE. In some places we use to use "set = !!set;". Please either do this or check by "!set"
> 

added set = !!set;

> > WebKit/efl/ewk/ewk_view.h:538
> > +EAPI Eina_Bool ewk_view_incognito_browsing_set(Evas_Object *o, Eina_Bool enable);
> 
> Follow the other cases on this header: it's Evas_Object* o, not Evas_Object *o

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.