[Webkit-unassigned] [Bug 51134] Move loading related code from MemoryCache to CachedResourceLoader

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 9 10:18:13 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51134





--- Comment #10 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-01-09 10:18:13 PST ---
(From update of attachment 76761)
View in context: https://bugs.webkit.org/attachment.cgi?id=76761&action=review

> WebCore/ChangeLog:19
> +        * css/CSSImageValue.cpp:
> +        (WebCore::CSSImageValue::cachedImage):
> +            
> +            Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
> +            if ever taken (since it passes null CachedResourceLoader pointer).

Are you sure this is the case? I have a sneaking suspicion that this change is causing random memory heap corruption issues, as being investigated here:

http://code.google.com/p/chromium/issues/detail?id=68516

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list