[Webkit-unassigned] [Bug 52054] [GTK] Port progressbar painting to GtkStyleContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52054


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78224|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-01-08 12:43:03 PST ---
(From update of attachment 78224)
View in context: https://bugs.webkit.org/attachment.cgi?id=78224&action=review

Looks great, but please see below before landing this.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:369
> +static const int progressActivityBlocks = 5;
> +static const int progressAnimationFrames = 10;
> +static const double progressAnimationInterval = 0.125;

Include a comment before these values which explains where they originate from.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:411
> +        double progress = renderProgress->animationProgress();

I think this should be called animationProgress, to avoid confusing it with the actual progress position. Please just rename before landing. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.