[Webkit-unassigned] [Bug 48509] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy, WebView classes for WebKit2 and add WKAPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48509





--- Comment #9 from Balazs Kelemen <kbalazs at webkit.org>  2011-01-08 12:42:29 PST ---
(From update of attachment 78232)
View in context: https://bugs.webkit.org/attachment.cgi?id=78232&action=review

Some thoughts from a non-reviewer.

> WebKit2/WebProcess/WebPage/ChunkedUpdateDrawingArea.h:74
> +#if PLATFORM(GTK)
> +    // to destroy the shared memory that is created in setSize

Please use full sentences with capital letter and dot at the end.

> WebKit2/WebProcess/WebPage/ChunkedUpdateDrawingArea.h:78
> +    HashMap <uint32_t, void*> xIDMap;

Seems like simply owning the UpdateChunk would be more straightforward than the map.
The drawing area is acting on exactly one chunk at a time so the map would never has more than one item.
In didUpdate you can release the owned chunk.

> WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:67
> +    // BitBlt from the backing-store to the window.
> +    gdk_draw_drawable(window, gc, m_backingStoreBitmap, rect.x(), rect.y(), rect.x(), rect.y(), rect.width(), rect.height());
> +    g_object_unref(gc);

BitBlt is a Windows API function. I guess you wont refer to that here :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.