[Webkit-unassigned] [Bug 52107] SVG rendering clean up according to the webkit style rules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52107





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-01-08 11:38:51 PST ---
(From update of attachment 78307)
View in context: https://bugs.webkit.org/attachment.cgi?id=78307&action=review

> WebCore/rendering/RenderSVGModelObject.h:70
> -    bool nodeAtPoint(const HitTestRequest& request, HitTestResult& result, int xInContainer, int yInContainer, int dxParentToContainer, int dyParentToContainer, HitTestAction hitTestAction);
> +    bool nodeAtPoint(const HitTestRequest&, HitTestResult&, int xInContainer, int yInContainer, int dxParentToContainer, int dyParentToContainer, HitTestAction);

This change doesn't seem valuable.  How else will we know which one is the request and which one is the result?

> WebCore/rendering/RenderSVGResourceFilterPrimitive.h:47
> -    static FloatRect determineFilterPrimitiveSubregion(FilterEffect* effect, SVGFilter* filter);
> +    static FloatRect determineFilterPrimitiveSubregion(FilterEffect*, SVGFilter*);

Same thing here.

> WebCore/rendering/RenderSVGRoot.cpp:324
> -bool RenderSVGRoot::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, int _x, int _y, int _tx, int _ty, HitTestAction hitTestAction)
> +bool RenderSVGRoot::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, int x, int y, int tx, int ty, HitTestAction hitTestAction)
>  {
> -    IntPoint pointInContainer(_x, _y);
> -    IntSize containerToParentOffset(_tx, _ty);
> +    IntPoint pointInContainer(x, y);
> +    IntSize containerToParentOffset(tx, ty);

I don't understand this code well enough to know whether this is a good change.  I think _x might mean something in the rendering code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.