[Webkit-unassigned] [Bug 48511] [GTK] Implement Process/Thread Launcher classes and WebProcessGtkMain for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48511





--- Comment #15 from Amruth Raj <amruthraj at motorola.com>  2011-01-08 11:36:04 PST ---
(In reply to comment #13)
> (From update of attachment 78312 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78312&action=review
> 
> Thanks for the quick update! There's one more significant issue here that I can see before landing.
> 
> > WebCore/platform/gtk/FileSystemGtk.cpp:196
> > +    String filename = filenameToString(pathFromProc);
> > +    return directoryName(filename).utf8();
> 
> Here you should just return pathFromProc. Sorry that I wasn't clear about that. Converting a CString to a String directly assumes that it's in the latin1 encoding. And then using the UTF-8 encoding might break the subsequent call to execl if the target filesystem is not UTF-8 encoded.
> 
> > WebCore/platform/gtk/FileSystemGtk.cpp:204
> > +    String filename = filenameToString(currentExePath.get());
> > +    return directoryName(fileName).utf8();
> 
> Please just return currentExePath here.

Addressed the comments above. Not doing any encoding now and just returning pathFromProc/currentExePath

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.