[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78253|review+                     |review-
               Flag|                            |




--- Comment #20 from Alexey Proskuryakov <ap at webkit.org>  2011-01-07 12:05:27 PST ---
(From update of attachment 78253)
+    RefPtr<CSSStyleSheet> m_sheet;
+    bool m_loading;
+    bool m_disabled;
+    KURL m_url;
+    RelAttribute m_relAttribute;
+    String m_type;
+    String m_media;
+    String m_charset;
+    String m_title;

It seems extremely counter-intuitive to have these in a loader class. 

+LinkLoader::~LinkLoader()
+{
+    if (sheet())
+        sheet()->clearOwnerNode();

Link loader is not a node, why does is its destructor call clearOwnerNode()?

Maybe it's only the "LinkLoader" class name, and the refactoring is good otherwise, but the new mix of loading, DOM and CSSOM code feels like a wrong direction to take to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.