[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78248|review?                     |review+
               Flag|                            |




--- Comment #15 from Adam Barth <abarth at webkit.org>  2011-01-07 11:40:51 PST ---
(From update of attachment 78248)
View in context: https://bugs.webkit.org/attachment.cgi?id=78248&action=review

This looks great.  Some extremely minor nits below.  I look forward to the next patch.  :)

> WebCore/WebCore.xcodeproj/project.pbxproj:-22334
> -			developmentRegion = English;

Probably better not to fight the developmentRegion war.

> WebCore/html/HTMLLinkElement.h:60
> +    //    bool isIcon() const { return m_relAttribute.m_isIcon; }

Please remove commented out code.

> WebCore/html/HTMLLinkElement.h:77
> +

extra blank line.

> WebCore/loader/LinkLoaderClient.h:37
> +

extra space

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.