[Webkit-unassigned] [Bug 50254] Canceled frame loads can corrupt back forward list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50254





--- Comment #9 from Charles Reis <creis at chromium.org>  2011-01-07 09:56:47 PST ---
(From update of attachment 78175)
View in context: https://bugs.webkit.org/attachment.cgi?id=78175&action=review

New patch ready for review.

>> WebCore/loader/HistoryController.cpp:657
>> +    // Note: If item1 and item2 are the same, then we need to create a new
> 
> This comment (which I realize predates your patch, you just moved it around) always bothered me, since it's just stating what the code does, but doesn't explain why that behavior is desired/necessary.  Based on http://webkit.org/b/35532 (which is the oldest reference to it that I can find), it seems like some WebKit clients use navigation to the current history item as a reload mechanism. Perhaps you can mention that (and/or the bug number) so that the comment provides some justification for the behavior?

Thanks for figuring out why it's the case!  I've updated the comment as you suggest.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.