[Webkit-unassigned] [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 20:00:39 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=48781





--- Comment #20 from WebKit Commit Bot <commit-queue at webkit.org>  2011-01-06 20:00:38 PST ---
Attachment 78148 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/images/resources/broken-image-with-invalid-format.png', u'LayoutTests/fast/images/support-broken-image-delegate.html', u'LayoutTests/platform/mac/fast/images/support-broken-image-delegate-expected.txt', u'Tools/ChangeLog', u'Tools/DumpRenderTree/LayoutTestController.cpp', u'Tools/DumpRenderTree/LayoutTestController.h', u'Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm', u'WebCore/ChangeLog', u'WebCore/loader/FrameLoaderClient.h', u'WebCore/loader/cache/CachedImage.cpp', u'WebCore/loader/cache/CachedImage.h', u'WebKit/mac/ChangeLog', u'WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h', u'WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'WebKit/mac/WebView/WebDelegateImplementationCaching.h', u'WebKit/mac/WebView/WebDelegateImplementationCaching.mm', u'WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h', u'WebKit/mac/WebView/WebView.mm']" exit_code: 1
Tools/DumpRenderTree/LayoutTestController.h:305:  The parameter name "shouldPaintBrokenImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list