[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50901


James Kozianski <koz at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78188|1                           |0
        is obsolete|                            |




--- Comment #19 from James Kozianski <koz at chromium.org>  2011-01-06 18:35:33 PST ---
(From update of attachment 78188)
View in context: https://bugs.webkit.org/attachment.cgi?id=78188&action=review

>> Tools/ChangeLog:12

> 
> Should be updated to include fileset.py

Done.

>> Tools/Scripts/webkitpy/common/directoryfileset.py:30

> 
> Given that filesystem lives in webkitpy.common.system, perhaps the fileset classes should be in there too.

Done.

>> Tools/Scripts/webkitpy/common/directoryfileset.py:44

> 
> Should use filesystem.join instead of os.path.join.

Done.

>> Tools/Scripts/webkitpy/common/directoryfileset.py:69

> 
> Same here.

Done.

>> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:117

> 
> del is actually a statement, this should be del self.files[path]

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.