[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50901





--- Comment #17 from Mihai Parparita <mihaip at chromium.org>  2011-01-06 16:52:59 PST ---
(From update of attachment 78188)
View in context: https://bugs.webkit.org/attachment.cgi?id=78188&action=review

> Tools/ChangeLog:12
> +        * Scripts/webkitpy/common/directoryfileset.py: Added.

Should be updated to include fileset.py

> Tools/Scripts/webkitpy/common/directoryfileset.py:30
> +from webkitpy.common.system.filesystem import FileSystem

Given that filesystem lives in webkitpy.common.system, perhaps the fileset classes should be in there too.

> Tools/Scripts/webkitpy/common/directoryfileset.py:44
> +        return os.path.join(self._path, filename)

Should use filesystem.join instead of os.path.join.

> Tools/Scripts/webkitpy/common/directoryfileset.py:69
> +        dest = os.path.join(path, filename)

Same here.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:117
> +        del(self.files[path])

del is actually a statement, this should be del self.files[path]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.