[Webkit-unassigned] [Bug 52011] New: JSC bindings should use RuntimeEnabledFeatures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 12:58:37 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52011

           Summary: JSC bindings should use RuntimeEnabledFeatures
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Enhancement
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jmason at rim.com
                CC: darin at apple.com, jorlow at chromium.org


Only the V8 bindings generate code to enable/disable Javascript features that have the EnabledAtRuntime attribute, even though the RuntimeEnabledFeatures class is in bindings/generic so it's available to JSC.  This would allow attributes to be completely removed if they are disabled (simply returning "undefined" is not good enough because they will still be visible in iteration).

This needs at least:

- code added to CodeGeneratorJS.pm to parallel that in CodeGeneratorV8.pm that checks EnabledAtRuntime (or better yet move these checks 
into common helpers)
- possibly added to the other CodeGenerator scripts as well?
- existing uses of RuntimeEnabledFeatures that are wrapped in "#if USE(V8)" need to be audited to see if they should now be unconditional
- RuntimeEnabledFeatures needs to be added to the build for all platforms using JSC

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list