[Webkit-unassigned] [Bug 51231] document.querySelector(':nth-child(foo)') should throw a syntax error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51231


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78110|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-01-06 08:16:38 PST ---
(From update of attachment 78110)
View in context: https://bugs.webkit.org/attachment.cgi?id=78110&action=review

> WebCore/css/CSSGrammar.y:1212
> +            }
> +            else

WebKit project style is to put the else on the same line as the close brace.

> WebCore/css/CSSParser.h:82
> +        bool isValidNthToken(const CSSParserString&);

This should be a static member function. There is no dependency here on the parser state, so no need for a non-static member function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.