[Webkit-unassigned] [Bug 50799] Add Memory Sampler to WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 01:26:22 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=50799


Stephanie Lewis <slewis at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slewis at apple.com




--- Comment #23 from Stephanie Lewis <slewis at apple.com>  2011-01-06 01:26:22 PST ---

> WebKit2/WebKit2Prefix.h:71
> +#if PLATFORM(MAC)
> +#define ENABLE_MEMORY_SAMPLER 1
> +#endif

I don't see this #define used anywhere. What's it for?


The memory part of the MemorySampler currently only works on Mac, so I am only adding the files to the mac build.  There are a couple of call sites in WebContext.cpp and WebProcess.cpp that call into those classes and I wrapped those in the #enable.  I should probably wrap the MemorySampler files in the #define as well even though they aren't even compiled on other platforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list