[Webkit-unassigned] [Bug 22759] dropdown menu disappears on mouse-over

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 18:13:07 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=22759





--- Comment #16 from dgrogan at google.com  2011-01-05 18:13:07 PST ---
(From update of attachment 76255)
View in context: https://bugs.webkit.org/attachment.cgi?id=76255&action=review

>> WebCore/css/CSSPrimitiveValue.cpp:439
>> +        return roundedResult;
> 
> Why compute roundedResult outside the if statement where it’s being returned? That seems like extra work for no benefit. I would write:
> 
>     if (!applyZoomMultiplier || multiplier == 1.0)
>         return shouldRound ? round(result) : result;
> 
> Or the equivalent with two if statements.

Agreed.  It was an artifact of some debug code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list