[Webkit-unassigned] [Bug 51974] New: Atomics.h has incorrect GCC test for ext/atomicity.h when using LSB compilers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51974

           Summary: Atomics.h has incorrect GCC test for ext/atomicity.h
                    when using LSB compilers
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: audiofanatic+webkit at gmail.com


In JacaScriptCore/wtf/Atomics.h the following code block can be found around line 64:

#if OS(WINDOWS)
#include <windows.h>
#elif OS(DARWIN)
#include <libkern/OSAtomic.h>
#elif OS(ANDROID)
#include <cutils/atomic.h>
#elif COMPILER(GCC) && !OS(SYMBIAN)
#if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))
#include <ext/atomicity.h>
#else
#include <bits/atomicity.h>
#endif
#endif

The test for the GCC version is not correct when the LSB compiler is being used under linux, since the LSB headers only have bits/atomicity.h and not ext/atomicity.h. A more correct test would be:

#if ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))) && !defined(__LSB_VERSION__)


For reference, the LSB and Qt bug trackers also have corresponding entries about this particular webkit issue:

http://bugs.linuxbase.org/show_bug.cgi?id=2522
http://bugreports.qt.nokia.com/browse/QTBUG-16329

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.