[Webkit-unassigned] [Bug 49511] RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49511





--- Comment #8 from Levi Weintraub <leviw at google.com>  2011-01-05 16:58:20 PST ---
(In reply to comment #7)
> Created an attachment (id=78065)
 --> (https://bugs.webkit.org/attachment.cgi?id=78065&action=review) [details]
> Patch

> > LayoutTests/editing/selection/rtl-move-selection-right-left.html:71
> > +    testSelectionChange(setSelection, "move", "right", 0, undefined);
> > +    testSelectionChange(setSelection, "move", "left", undefined, 0);
> Why don't we test end & start offsets for these two tests?  I think we should.

You're right. Fixed.

> (From update of attachment 75041 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75041&action=review
> 
> >> WebCore/editing/SelectionController.cpp:285
> >> +            }
> > 
> > I don't think we should be doing this for DirectionRight.  New code seems to make sense only for DirectionForward.
> > 
> > Dan & Xiaomei, could you comment on this?
> 
> Is it the other way around? the new change should only apply for DirectionRight/Left.

Xiaomei is right, it's really just for Right/Left. I've fixed willBeModified to only consider LTR for Left/Right.

> > WebCore/editing/SelectionController.cpp:426
> >          else
> 
> you probably forgot to enclose them into "{......}"
> 
> > WebCore/editing/SelectionController.cpp:579
> > +                pos = VisiblePosition(m_selection.end(), m_selection.affinity());
> 
> enclose in { }.

Looks like a bug in WebKit Style as well! Fixed :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.