[Webkit-unassigned] [Bug 51424] Add WebKitClient::createAudioDevice() for Chromium port of web audio API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51424


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77165|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-01-05 15:54:08 PST ---
(From update of attachment 77165)
View in context: https://bugs.webkit.org/attachment.cgi?id=77165&action=review

> WebKit/chromium/src/AudioDestinationChromium.cpp:47
> +const unsigned CallbackBufferSize = 2048;

I'm pretty sure the preferred style for constants is to use variableNaming style.

> WebKit/chromium/src/AudioDestinationChromium.cpp:105
> +    if (!isNumberOfChannelsGood)

nit: instead of repeating the expression, use ASSERT_NOT_REACHED if the branch is taken.

> WebKit/chromium/src/AudioDestinationChromium.cpp:110
> +    if (!isBufferSizeGood)

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.