[Webkit-unassigned] [Bug 51312] Make ContextShadow code cross-platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51312





--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-01-05 08:34:49 PST ---
(In reply to comment #6)
> (In reply to comment #0)
> > It would be nice if ContextShadow::drawRectShadow() were cross-platform. ImageBuffer could be used here, but we'd need direct pixel access to avoid having to copy to do blurring (see bug 51297).
> > 
> > Also somewhat related, bug 51309 talks about sharing blurring code between ContextShadow and FEGaussianBlur.
> 
> At least for drawRectShadow() I don't believe that direct pixel access makes a big difference. I bet (you may have checked for your self), that the general case will be 100x100 pixel for the temporary ImageBuffer for blurring operations. The copy operations carry no weight for such a small image. I don't want to prevent you to add direct pixel access, but the first implementation doesn't need to have it.

I agree that in my measurements the blur cost was much higher than the copy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.