[Webkit-unassigned] [Bug 51885] [GTK] Fix gtk2 compilation for master

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51885





--- Comment #3 from Alejandro G. Castro <alex at igalia.com>  2011-01-05 04:37:38 PST ---
(In reply to comment #2)
> (From update of attachment 77912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77912&action=review
> 
> > Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:43
> > +    gdk_pixmap_get_size(GDK_DRAWABLE(pixmap), &width, &height);
> 
> This is confusing, I think you should make the macro do nothing in newer versions. But then the code will be a mess to understand... ugh :/(the fact that it still compiles tells me the GTK+ guys dropped the ball by now).
> 

Yep, I can add that or even try to remove the gtk2 code and use other way to get the size.

> > WebKit/gtk/webkit/webkitsoupauthdialog.c:230
> > +    g_object_set(dialog, "has-separator", FALSE, NULL);
> 
> Let's just remove the separator? It's not like we have to have one or anything :)

Actually we are removing it with the code, but yeah, I do not think anything depends on not having it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.