[Webkit-unassigned] [Bug 51695] check-webkit-style treated some macros with parentheses after #elif as function calls

Tue Jan 4 17:26:20 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=51695

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77947|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #7 from David Levin <levin at chromium.org>  2011-01-04 17:26:20 PST ---
(From update of attachment 77947)
Really close!

It looks good but it needs a simple test to verify it. See cpp_unittest.py. Look for the error "Extra space before (" to see where similar tests are and add one which verifies that you don't get the error for the false positive (#elif if I remember correctly).

Run the test using "test-webkitpy" to verify that your test passes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.