[Webkit-unassigned] [Bug 48957] [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48957





--- Comment #12 from Robert Hogan <robert at webkit.org>  2011-01-04 12:24:12 PST ---
(In reply to comment #10)
> (From update of attachment 75941 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75941&action=review
> 
> > WebCore/bridge/qt/qt_runtime.cpp:137
> > +// this is here as a proxy, so we'd have a class to friend in QDRTNode,
> 
> Capital T.
> 
> > WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:91
> > +        m_node = static_cast<Node*>(node);
> 
> Do you need to static_cast Node* to Node*?

When fixing up per your comments I realized we should make the expected results less platform-specific. Proposed change to results in the patch. Do you agree?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.